Add one extra page to avoid colliding with the next page being rounded down #446 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added testcase. I took the binary from the issue #446 and used 4b645c7 to remove all the dangerous stuff from it. It now compresses much better, and we don't have the risk of running arbitrary code. The program will simply crash if you try to run it. Unfortunately, it only runs on x86_64, but I guess it's better than nothing. |
brenoguim
force-pushed
the
breno.446
branch
2 times, most recently
from
4217a09
to
b012146
Compare
brenoguim
changed the title
Mic92
reviewed
Feb 23, 2023
|
I'm pretty sure I messed this up. I didn't realize the master was merged into my PR. Might need to open another one. As soon as I find my code :) |
|
Continues at #469 sorry for the mess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote my analysis on #446 it seems that this patch fixes the issue. It adds one extra page in the "needed space". Not because the current segment needs it, but because its possible that a following segment is unaligned (and read only).
In such situation there would be a range of addresses loaded by two segments, and the read-only wins.
There is a better way to do this (check the segment for example). But I wanted to share the patch to start a discussion.
Also, it would be very important to come up with a test for this. It would be very easy to break it again while refactoring.