Do not let modifyRPath taint shared strings in strtab. Fix #315 #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenoguim
changed the title
|
bors merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I add a method to iterate over all fields of the ELF file (as best as we can) that represent indexes in strtable.
I use this method to check if the RPATH string being changed in
modifyRPATHis shared among multiple fields. If it's shared, don't let patchelf taint the field.We hope that patchelf continues to taint the vast majority of rpaths (as needed by Nix) but only refrain from doing so when it will break the binary.
Note: The first commit changes the section tainting from X to Z so I can look for the Xs in my tests.