-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC 0140] Simple Package Paths #140
Merged
Merged
Commits on Jan 30, 2023
-
Initialized from nixpkgs-architecture/simple-package-paths@01948e0
Configuration menu - View commit details
-
Copy full SHA for 3ca531a - Browse repository at this point
Copy the full SHA 3ca531aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 269ac4f - Browse repository at this point
Copy the full SHA 269ac4fView commit details
Commits on Feb 2, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 21c3493 - Browse repository at this point
Copy the full SHA 21c3493View commit details
Commits on Mar 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e203231 - Browse repository at this point
Copy the full SHA e203231View commit details -
Configuration menu - View commit details
-
Copy full SHA for 967beb1 - Browse repository at this point
Copy the full SHA 967beb1View commit details
Commits on Apr 17, 2023
-
Mid-sized refactor for improved clarity and incorporating feedback
In addition to some more minor changes and incorporating feedback, the major changes are: - Restructure the RFC into two separate parts, one to introduce the convention and one to migrate packages to it when possible - Remove the restriction that files inside a unit directory can only be referenced by the corresponding `pkgs.${name}`. It feels very unnatural to have this restriction and it's hard to reason about it. Files inside a unit directory still can't reference anything _outside_ the unit directory, which is very similar to Nix's concept of allowed-uris, which may be used to implement this check in the future. - Remove the special case of allowing custom arguments. By not having this one exception, users viewing a unit directory can be sure that there's no hidden semantics anywhere (overriding arguments) and that the functions arguments correspond directly to attributes in `pkgs`, no exceptions that would require looking at `all-packages.nix`. And it would be weird just to allow this one exception of `callPackage` with custom arguments, when there's a lot of other similarly small exceptions we could make, like allowing `python3Packages.callPackage`. - Remove the requirement that new packages must use this standard. Especially with the above exception removed, this standard is now more strict and less packages satisfy it by default. A scenario could be that a user adds a new package, initially not needing custom arguments, so CI requires it to be in `pkgs/unit`, but then a custom argument is needed, so it must be moved out of there and added to `all-packages.nix`. But then the custom argument can be removed, so it _must_ be in `pkgs/unit` again. This sucks. So let's keep `all-packages.nix` unrestricted, so a package won't have to be moved back and forth like this.
Configuration menu - View commit details
-
Copy full SHA for b077e2f - Browse repository at this point
Copy the full SHA b077e2fView commit details
Commits on May 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1d7e66a - Browse repository at this point
Copy the full SHA 1d7e66aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0054e7a - Browse repository at this point
Copy the full SHA 0054e7aView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffad8ea - Browse repository at this point
Copy the full SHA ffad8eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66f0225 - Browse repository at this point
Copy the full SHA 66f0225View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89ea8e7 - Browse repository at this point
Copy the full SHA 89ea8e7View commit details
Commits on May 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4426f20 - Browse repository at this point
Copy the full SHA 4426f20View commit details
Commits on May 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4f0c06f - Browse repository at this point
Copy the full SHA 4f0c06fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 98f8287 - Browse repository at this point
Copy the full SHA 98f8287View commit details
Commits on May 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e6bd2f5 - Browse repository at this point
Copy the full SHA e6bd2f5View commit details
Commits on May 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 632fb4d - Browse repository at this point
Copy the full SHA 632fb4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71e40dc - Browse repository at this point
Copy the full SHA 71e40dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 46c23ae - Browse repository at this point
Copy the full SHA 46c23aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7c3056 - Browse repository at this point
Copy the full SHA f7c3056View commit details -
Configuration menu - View commit details
-
Copy full SHA for f53a862 - Browse repository at this point
Copy the full SHA f53a862View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5b2019 - Browse repository at this point
Copy the full SHA e5b2019View commit details
Commits on May 29, 2023
-
Co-Authored-By: Robert Hensing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b72d482 - Browse repository at this point
Copy the full SHA b72d482View commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 7a03d43 - Browse repository at this point
Copy the full SHA 7a03d43View commit details
Commits on Jun 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 13c4f39 - Browse repository at this point
Copy the full SHA 13c4f39View commit details -
Apply suggestions from code review
Remove the barely used term "base directory" Co-authored-by: Robert Hensing <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f15c1cf - Browse repository at this point
Copy the full SHA f15c1cfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.