Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC 0140] Simple Package Paths #140

Merged
merged 25 commits into from
Jul 12, 2023
Merged

Commits on Jan 30, 2023

  1. RFC 140

    infinisil committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    3ca531a View commit details
    Browse the repository at this point in the history
  2. Minor improvements

    infinisil committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    269ac4f View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Minor nits

    infinisil committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    21c3493 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Configuration menu
    Copy the full SHA
    e203231 View commit details
    Browse the repository at this point in the history
  2. pkg-fun.nix -> package.nix

    infinisil committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    967beb1 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2023

  1. Mid-sized refactor for improved clarity and incorporating feedback

    In addition to some more minor changes and incorporating feedback, the
    major changes are:
    - Restructure the RFC into two separate parts, one to introduce
      the convention and one to migrate packages to it when possible
    - Remove the restriction that files inside a unit directory can only be
      referenced by the corresponding `pkgs.${name}`. It feels very
      unnatural to have this restriction and it's hard to reason about it.
      Files inside a unit directory still can't reference anything _outside_
      the unit directory, which is very similar to Nix's concept of allowed-uris,
      which may be used to implement this check in the future.
    - Remove the special case of allowing custom arguments. By not having
      this one exception, users viewing a unit directory can be sure that
      there's no hidden semantics anywhere (overriding arguments) and that the
      functions arguments correspond directly to attributes in `pkgs`, no
      exceptions that would require looking at `all-packages.nix`.
      And it would be weird just to allow this one exception of
      `callPackage` with custom arguments, when there's a lot of other
      similarly small exceptions we could make, like allowing
      `python3Packages.callPackage`.
    - Remove the requirement that new packages must use this standard.
      Especially with the above exception removed, this standard is now more
      strict and less packages satisfy it by default.
      A scenario could be that a user adds a new package, initially not
      needing custom arguments, so CI requires it to be in `pkgs/unit`, but
      then a custom argument is needed, so it must be moved out of there and
      added to `all-packages.nix`. But then the custom argument can be removed,
      so it _must_ be in `pkgs/unit` again. This sucks.
      So let's keep `all-packages.nix` unrestricted, so a package won't have
      to be moved back and forth like this.
    infinisil committed Apr 17, 2023
    Configuration menu
    Copy the full SHA
    b077e2f View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Configuration menu
    Copy the full SHA
    1d7e66a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0054e7a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ffad8ea View commit details
    Browse the repository at this point in the history
  4. Mention package variants

    infinisil committed May 11, 2023
    Configuration menu
    Copy the full SHA
    66f0225 View commit details
    Browse the repository at this point in the history
  5. Minor moving and formatting

    infinisil committed May 11, 2023
    Configuration menu
    Copy the full SHA
    89ea8e7 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Configuration menu
    Copy the full SHA
    4426f20 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. Configuration menu
    Copy the full SHA
    4f0c06f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    98f8287 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Configuration menu
    Copy the full SHA
    e6bd2f5 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. Configuration menu
    Copy the full SHA
    632fb4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    71e40dc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    46c23ae View commit details
    Browse the repository at this point in the history
  4. Add shepherd team and nicks

    infinisil committed May 17, 2023
    Configuration menu
    Copy the full SHA
    f7c3056 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f53a862 View commit details
    Browse the repository at this point in the history
  6. Fix table rendering

    infinisil committed May 17, 2023
    Configuration menu
    Copy the full SHA
    e5b2019 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. Minor fixups

    Co-Authored-By: Robert Hensing <[email protected]>
    infinisil and roberth committed May 29, 2023
    Configuration menu
    Copy the full SHA
    b72d482 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    7a03d43 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. unit -> by-name, remove "standard"

    And some very minor changes
    infinisil committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    13c4f39 View commit details
    Browse the repository at this point in the history
  2. Apply suggestions from code review

    Remove the barely used term "base directory"
    
    Co-authored-by: Robert Hensing <[email protected]>
    infinisil and roberth committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    f15c1cf View commit details
    Browse the repository at this point in the history