[DevOps] - Migrate to Node 18

[Ari-S-123]

Description

Migrate from Node 16 to Node 18. Node 16 will be at its End-of-Life on September 11, 2023, so this ticket should be completed by then.

Acceptance Criteria

There should not be any regressions from the migration, all features should work the same as before.

Proposed Solution

Run the app with node 18 and fix any issues that arise.

[acd124]

Problem 1: error:0308010C:digital envelope routines::unsupported
Solution: Upgrade react-scripts to version ^5.0.1
https://www.freecodecamp.org/news/error-error-0308010c-digital-envelope-routines-unsupported-node-error-solved/

[acd124]

Problem 2: ERROR in src/tests/pages/ChangeRequestDetailPage/ReviewChangeRequest.test.tsx:16:9
Something about missing wbsName in a type. Also see #1093
Should be fixed via another PR before this.
src/frontend/src/tests/pages/ChangeRequestDetailPage/ChangeRequestDetailsView.test.tsx also had similar issue, just missing a prop.

[acd124]

Problem 3: [eslint] Failed to load config "react-app" to extend from.
Solution should involve adding the react app eslint config as a dev dependency, might have to resolve version conflicts with react scripts. This error shows up as a popup in the frontend but clicking x lets you just run the app
yarn add eslint-config-react-app -D
error about conflicting versions only shows up once, unsure how to solve
See facebook/create-react-app#11759 for the possible source

[acd124]

Problem 4: Backend giving 500 errors with Error Unknown Forgot to update database

[acd124]

Regarding Problem 3: eslint for react
The root of the issue appears to be somewhere in react-scripts which may have a solution related to #619. This error does not affect normal app usage but may be a consistent annoyance in development.

[ninest]

@acd124 Does vite (#619) fix this 👀

[acd124]

@acd124 Does vite (#619) fix this 👀

Everything looks like it does, yes. I've run the app several times on node18 no issues from a blank slate develop branch. The other minor issues I documented here are likely not impacting regular development when using vite.