Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map branch name from sourcelink to RepositoryBranch for NuGet pack #13625

Closed
MattKotsenas opened this issue Jul 15, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5923
Closed

Map branch name from sourcelink to RepositoryBranch for NuGet pack #13625

MattKotsenas opened this issue Jul 15, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5923
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Feature

Comments

@MattKotsenas
Copy link

NuGet Product(s) Involved

NuGet.exe, dotnet.exe

The Elevator Pitch

This is a companion issue for dotnet/sourcelink#1243.

Once sourcelink emits the source branch name, NuGet should map that value to RepositoryBranch (and follow the existing rules around allowing the user to override).

Additional Context and Details

No response
@MattKotsenas MattKotsenas mentioned this issue Jul 15, 2024
Merged
3 tasks
@donnie-msft donnie-msft added Type:Engineering product/infrastructure work/not a customer bug/feature/DCR and removed Type:Feature Triage:Untriaged labels Jul 16, 2024
@nkolev92 nkolev92 added Type:Feature Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. and removed Type:Engineering product/infrastructure work/not a customer bug/feature/DCR labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Functionality:Pack Priority:3 Issues under consideration. With enough upvotes, will be reconsidered to be added to the backlog. Type:Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Map SourceBranchName from sourcelink to RepositoryBranch for NuGet pack MattKotsenas/NuGet.Client
3 participants
@MattKotsenas @nkolev92 @donnie-msft