Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate RepositoryBranch automatically #1243

Closed
MattKotsenas opened this issue Jun 27, 2024 · 2 comments · Fixed by #1248
Closed

Populate RepositoryBranch automatically #1243

MattKotsenas opened this issue Jun 27, 2024 · 2 comments · Fixed by #1248

Comments

@MattKotsenas
Copy link
Member

Following up from #188 and starting the discussion to populate RepositoryBranch automatically.

There are a few linked items in the old issue requesting this feature. Additionally, a new version of the DotNet.ReproducibleBuilds package was released, which sets this for some common CI providers (see dotnet/reproducible-builds#27). However, that has the side-effect of causing the nuspec to be different between a local build and a CI build (beyond what's already necessary).

I'm open to design discussions, but I'll propose an algorithm that's the same as the one currently provided by ReproducibleBuilds, with a fallback that's essentially git rev-parse --abbrev-ref HEAD (or similar) if no properties are provided.

@baronfel
Copy link
Member

I think this would be a great thing to have, and SourceLink is a reasonable place to ship it. @tmat do you have thoughts here?

@tmat
Copy link
Member

tmat commented Jun 28, 2024

Sounds good to me. We'd definitely accept a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants