-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: replace Portable.BouncyCastle with System.Formats.Asn1 #5937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtivel
commented
Jul 29, 2024
test/NuGet.Core.FuncTests/NuGet.Packaging.FuncTest/SigningTests/SignatureTests.cs
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/Asn.1/DirectoryString.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
dtivel
commented
Jul 29, 2024
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/CertificateRevocationListBuilder.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/CertificateRevocationListBuilder.Load.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/CertificateRevocationListBuilder.CdpExtension.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/CertificateRevocationListBuilder.Build.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/Asn.1/X509ExtensionAsn.xml.cs
Outdated
Show resolved
Hide resolved
dtivel
commented
Jul 29, 2024
test/TestUtilities/Test.Utility/Signing/X509RevocationReason.cs
Outdated
Show resolved
Hide resolved
zivkan
reviewed
Jul 30, 2024
nkolev92
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/969
Description
This change replaces our Portable.BouncyCastle test dependency with types that leverage System.Formats.Asn1 functionality.
BouncyCastle's alternate implementation of many cryptographic types provided a good baseline for our package signing tests. To remove BouncyCastle, I
With the exception of Directory.Packages.props, this PR only modifies files under /test.
Occasionally, I opportunistically also fixed IDE warnings/errors for unused code or format rule violations, such as constants with a leading
_
or unusedusing
statements.PR Checklist
Added testsN/ALink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.N/ACC @aortiz-msft, @kartheekp-ms