Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: replace Portable.BouncyCastle with System.Formats.Asn1 #5937

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

dtivel
Copy link
Contributor

@dtivel dtivel commented Jul 29, 2024

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/969

Description

This change replaces our Portable.BouncyCastle test dependency with types that leverage System.Formats.Asn1 functionality.

BouncyCastle's alternate implementation of many cryptographic types provided a good baseline for our package signing tests. To remove BouncyCastle, I

  • mostly recreated similar functionality using System.Formats.Asn1
  • copied a few implementations from dotnet/runtime
  • removed test coverage in a few situations

With the exception of Directory.Packages.props, this PR only modifies files under /test.

Occasionally, I opportunistically also fixed IDE warnings/errors for unused code or format rule violations, such as constants with a leading _ or unused using statements.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests N/A
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc. N/A

CC @aortiz-msft, @kartheekp-ms

@dtivel dtivel requested a review from a team as a code owner July 29, 2024 15:25
Directory.Packages.props Outdated Show resolved Hide resolved
@dtivel dtivel merged commit 29c64d4 into dev Jul 30, 2024
28 of 29 checks passed
@dtivel dtivel deleted the dev-dtivel-remove-bc branch July 30, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants