Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Re-enable Mac Mono Tests #5945

Merged
merged 4 commits into from
Aug 1, 2024
Merged

[CI] Re-enable Mac Mono Tests #5945

merged 4 commits into from
Aug 1, 2024

Conversation

jeffkl
Copy link
Contributor

@jeffkl jeffkl commented Jul 31, 2024

Bug

Fixes: https://github.com/NuGet/Client.Engineering/issues/2926

Description

This re-enables the Mac Mono tests after they were disabled due to not working after a change. I had to bring back the xunit.runner.json for some reason. I spent a lot of time trying to use newer tooling but that seems to be broken. So I really just brought them back the way there were before.

PR Checklist

  • Meaningful title, helpful description and a linked NuGet/Home issue
  • Added tests
  • Link to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.

@jeffkl jeffkl added the Engineering Changes related to the build infrastructure of the repo and that do not change product code label Jul 31, 2024
@jeffkl jeffkl self-assigned this Jul 31, 2024
@jeffkl jeffkl requested a review from a team as a code owner July 31, 2024 22:12
@jeffkl
Copy link
Contributor Author

jeffkl commented Jul 31, 2024

nkolev92
nkolev92 previously approved these changes Jul 31, 2024
zivkan
zivkan previously approved these changes Jul 31, 2024
eng/pipelines/official.yml Outdated Show resolved Hide resolved
@jeffkl jeffkl dismissed stale reviews from zivkan and nkolev92 via de9f574 August 1, 2024 00:50
@jeffkl jeffkl enabled auto-merge (squash) August 1, 2024 16:33
@jeffkl jeffkl disabled auto-merge August 1, 2024 20:54
@jeffkl jeffkl merged commit dc44240 into dev Aug 1, 2024
26 of 28 checks passed
@jeffkl jeffkl deleted the dev-jeffkl-fix-mono-tests branch August 1, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Changes related to the build infrastructure of the repo and that do not change product code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants