Stop compiling unused shared code into assemblies #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zivkan
force-pushed
the
dev-zivkan-shared-code
branch
from
0c5635c
to
9e87a02
Compare
jeffkl
previously approved these changes
Aug 2, 2024
nkolev92
reviewed
Aug 2, 2024
nkolev92
previously approved these changes
Aug 2, 2024
...Get.Clients/NuGet.PackageManagement.VisualStudio/NuGet.PackageManagement.VisualStudio.csproj
Outdated
Show resolved
Hide resolved
dtivel
previously approved these changes
Aug 5, 2024
...Get.Clients/NuGet.PackageManagement.VisualStudio/NuGet.PackageManagement.VisualStudio.csproj
Outdated
Show resolved
Hide resolved
jeffkl
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: https://github.com/NuGet/Client.Engineering/issues/2950
Description
Stop adding
build/Shared/*.csto allsrc/projects, and only include the minimum needed to build each project.This decreases the size of:
NuGet.exe by about 150kb
NuGet.vsix by about 200kb, and about 500kb when installed/unzipped
I don't have a trivial way to estimate the impact on the .NET SDK, but NuGet.Build.Tasks.Console's bin directory decreased in size by about 600kb
In addition to making it a smaller download for customers when upgrading VS, the .NET SDK, or NuGet.exe (CDN cost savings?), the VS Perf team tells me that it will have a benefit in decreased ngen time after VS upgrades, and that low priority ngen is timeboxed, meaning the less time spent ngen needless NuGet IL, the more time it has to ngen other assemblies before the timeout is reached, and therefore less code missing ngen when VS is actually launched.
PR Checklist
Added testsno code changesLink to an issue or pull request to update docs if this PR changes settings, environment variables, new feature, etc.no product changes