Fix broken links in Design Review Guide #5948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
approved these changes
Aug 2, 2024
|
@nkolev92 it looks like this path doesn't trigger CI. Maybe you can merge it without that since it's docs. |
|
I think we might need to revert the change for md, or tweak it. While I can merge this, I don't this is a good long term solution. Force merging is disabled by default. cc @zivkan in case he has an idea: NuGet.Client/eng/pipelines/pr.yml Lines 45 to 47 in 4d41382 |
|
PrivateDev was triggered either since the branch name doesn't start with |
donnie-msft
changed the base branch from
dev
to
dev-donnie-msft-designReviewGuide
donnie-msft
merged commit 9e15727
into
dev-donnie-msft-designReviewGuide
2 checks passed
aortiz-msft
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update links and remove the Design review workflow image which I couldn't find.