-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use concurrent dictionary in related extensions calculation #5951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we try to incorporate the check that failed in the SDK, or perhaps trigger the SDK tests for certain changes in our repo? That might help us catch these before insertion time.
The existing tests didn't catch the bug, so from the point of view of the checklist, I don't think the existing tests count. |
The tests there are a bit involved and involve static graph builds, not regular builds (unrelated from static graph restore). I can create an issue as a follow-up since this is blocking an insertion, but I'm not sure the effort is worth given that it was caught in the SDK repo. |
Created an issue: NuGet/Home#13678 |
Interesting thing; https://dev.azure.com/dnceng-public/public/_build/results?buildId=766638&view=ms.vss-test-web.build-test-results-tab&runId=19539484&resultId=100859&paneView=debug. That PR had a failure due to the concurrent dictionary. I'll look into it, maybe there's hope for an easier test. |
Bug
Related: NuGet/Home#12728
Description
It's failing the insertion: dotnet/sdk#42458.
PR Checklist
Added testsFunctional tests exist. The SDK side that caught this test out graph build scenarios, which are more challenging to replicate. Since this is blocking an insertion, I have created a follow issue. Replicate NET SDK static graph build tests Home#13678