-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details Pane shows Package Owner profile links on Browse Tab #5961
Conversation
…ailedPackageMetadata
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -1729,6 +1731,51 @@ public void SetInstalledOrUpdateButtonIsEnabled_AfterPackageSourceMappingChanges | |||
nameof(PackageSolutionDetailControlModel.CanUninstall) + " should have raised a PropertyChanged when calling " | |||
+ nameof(DetailControlModel.SetInstalledOrUpdateButtonIsEnabled) + " and the value should become true."); | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove extra blank line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll get this in my next iteration
Bug
Fixes: NuGet/Home#13686
Fixes: NuGet/Home#10666
Spec
Description
Render Owner profile hyperlinks consistent with how it's done on the packages list.
![image](https://private-user-images.githubusercontent.com/49205731/355995529-5ba52dd5-6013-4efe-9e0b-18946196bf0b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU5ODM5NzUsIm5iZiI6MTcyNTk4MzY3NSwicGF0aCI6Ii80OTIwNTczMS8zNTU5OTU1MjktNWJhNTJkZDUtNjAxMy00ZWZlLTllMGItMTg5NDYxOTZiZjBiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEwVDE1NTQzNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc3MjIzMzhiNWEyNTUwNWU0NGRmNTI2NTg2MmNhNWFkM2QwMjAyNTRjMGQ2MTg4OTBkMjJiODJjYjEyN2E0ZDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.NWrCbEtEnFhNe0hBQBSEZPJUU2X9pYBZjaMZmx-edII)
KnownOwnerViewModels
from the package item into the detail pane's model.The only scenario where this could happen was with a local package source with an owner specified in the nuspec. It did not occur for remote/V3 package sources.
Other notes:
ImmutableList
toImmutableArray
, but this caused too many new issues, so I'll do that separately.Accessibility
PR Checklist