Details Pane shows Package Owner profile links on Browse Tab #5961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailedPackageMetadata
jebriede
approved these changes
Aug 8, 2024
| @@ -1729,6 +1731,51 @@ public void SetInstalledOrUpdateButtonIsEnabled_AfterPackageSourceMappingChanges | |||
| nameof(PackageSolutionDetailControlModel.CanUninstall) + " should have raised a PropertyChanged when calling " | |||
| + nameof(DetailControlModel.SetInstalledOrUpdateButtonIsEnabled) + " and the value should become true."); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
nit: remove extra blank line.
There was a problem hiding this comment.
I'll get this in my next iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#13686
Fixes: NuGet/Home#10666
Spec
Description
Render Owner profile hyperlinks consistent with how it's done on the packages list.
KnownOwnerViewModelsfrom the package item into the detail pane's model.The only scenario where this could happen was with a local package source with an owner specified in the nuspec. It did not occur for remote/V3 package sources.
Other notes:
ImmutableListtoImmutableArray, but this caused too many new issues, so I'll do that separately.Accessibility
PR Checklist