Make errors more readable #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gekkowrld
commented
Jul 4, 2024
gekkowrld
commented
- feat: Add additional fields to token.Token struct
- chore: Convert parser errors to 'Syntax Error'
Add `Filename` and `Line` in preparation to enhance error reporting. The extra fields should be suited to provide consise error reporting when an error occurs. Signed-off-by: Gekko Wrld <[email protected]>
The parser doesn't emit its own errors, it relies on 'errd' package to do so. This makes it easier to format the error messages in a uniform parsable form. Instead of: Mstari 1: Tumeshindwa kuparse HARAMU Its: Kosa la kisintaksia: h.nr:1:4 Tumeshindwa kuparse '#' This gives the user the hint where the problem is and what caused the problem. Parser errors doesn't exit after display. Signed-off-by: Gekko Wrld <[email protected]>
Previuos implementation counted the rows and columns inconsistently. This fix will enable counting to be consistent and better. - Use strings.Builder in `readString` function instead of naive string concatenation This reduces memory allocation and deallocation being done by go making the program efficient. Signed-off-by: Gekko Wrld <[email protected]>
The line in which the error occured in is now displayed along with the error. This makes it easier to see what went wrong at a glance without opening the file to confirm. A caret is placed at the start of the error token to help the user know where they can start fixing from. Signed-off-by: Gekko Wrld <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.