Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use separated headers #1142

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Use separated headers #1142

merged 3 commits into from
Jul 30, 2024

Conversation

Halbaroth
Copy link
Collaborator

Use separated headers to distinguish our contributions.

@Halbaroth Halbaroth added this to the 2.6.0 milestone Jun 7, 2024
@Halbaroth Halbaroth force-pushed the separated-headers branch 3 times, most recently from fa5e53d to ea5a2df Compare June 10, 2024 12:58
@Halbaroth
Copy link
Collaborator Author

Is it better @bclement-ocp ?

@bclement-ocp
Copy link
Collaborator

I meant that the year should ideally depend on the file. If we can't do that, keeping the start of the project date (2013) everywhere is better.

@Halbaroth
Copy link
Collaborator Author

So you want a copyright of the form 2013-xxxx where xxxx is the last year we have modified the file?

@bclement-ocp
Copy link
Collaborator

I don't really see the point of this format: the main point here is to not claim copyright before the code was actually written.

So ideally we would have XXXX - YYYY where XXXX is the year the file was created and YYYY is the year it was last modified, but XXXX - 2024 where XXXX is the year the file was created works too.

If that is technically challenging with the tools we have, 2013 - 2024 is the next best (and simplest) option. My understanding is that the copyright years in the notice are informational only anyways.

Use separated headers to distinguish our contributions.
@Halbaroth
Copy link
Collaborator Author

I removed years in all the headers as we decided during the last dev meeting.

@Halbaroth Halbaroth requested review from bclement-ocp and removed request for bclement-ocp July 22, 2024 14:41
@bclement-ocp
Copy link
Collaborator

I think this is correct wrt the files changed. I understood we chose the option of keeping "2013 - 2024" everywhere, but dropping the years is fine by me should be fine (this is what curl did recently, and code from big companies such as VScode do not have copyright years) and should simplify our life. Would prefer an ack from @lefessan or @Ninjapouet before merging.

@Halbaroth
Copy link
Collaborator Author

I think we can merge. It is really easy to rollback it with ack ;)

@Halbaroth
Copy link
Collaborator Author

Fabrice agreed so we can merge @bclement-ocp

@Halbaroth Halbaroth merged commit f7796d1 into OCamlPro:next Jul 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants