Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: List files in an archive #22

Closed
Aloso opened this issue Jun 26, 2020 · 6 comments
Closed

Feature request: List files in an archive #22

Aloso opened this issue Jun 26, 2020 · 6 comments
Assignees
@Asakiz
Labels
enhancement New feature or request

Comments

@Aloso
Copy link

Aloso commented Jun 26, 2020

I'd like to use this crate to show comic book archives in emulsion. To do this, I need to iterate over all the files in an archive. Would it be possible to add a function that returns all file names in the archive?
@Jonathas-Conceicao
Copy link
Member

@Aloso I think it can easily be done. It's an useful feature we have been thinking about adding as well. @Asakiz, will get to it soon.

@Jonathas-Conceicao Jonathas-Conceicao added the enhancement New feature or request label Jun 26, 2020
@Aloso
Copy link
Author

Aloso commented Jun 26, 2020

Thanks a lot!

@Asakiz
Copy link
Contributor

Asakiz commented Jun 27, 2020 •
edited
Loading

Sorry @Aloso for the delay, but we have good news.
We added one function:

  • Get all file names in a archive: list_archive_files

Also, I added the documentation and modified the example to show the new feature.

We will only do some tests and launch the new version of the crate.

@otavio
Copy link
Member

otavio commented Jun 27, 2020

@Aloso, I'll move this discussion to the PR #23 so we keep it focused there.

otavio pushed a commit that referenced this issue Jun 28, 2020
@Asakiz @otavio
Add functions to list all file names in a archive
b0f79a6 
Fixes: #22
Signed-off-by: asakiz <[email protected]>
otavio pushed a commit that referenced this issue Jun 28, 2020
@Asakiz @otavio
Add functions to list all file names in a archive
e51c023 
Fixes: #22
Signed-off-by: asakiz <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
@otavio otavio closed this as completed in eb6341a Jun 28, 2020
@otavio
Copy link
Member

otavio commented Jun 28, 2020

@Aloso could you give the master branch a try? As we changed the MSRV we will do a breaking release but I'd like you to give it a try prior we make a release.

otavio pushed a commit that referenced this issue Jun 28, 2020
@Asakiz @otavio
Add functions to list all file names in a archive
76822f2 
Fixes: #22
Signed-off-by: asakiz <[email protected]>
Signed-off-by: Otavio Salvador <[email protected]>
@Aloso
Copy link
Author

Aloso commented Jun 28, 2020

Yes, I will. But I have to sleep first, it's already 3 a.m. where I live :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Asakiz Asakiz

Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
4 participants
@otavio @Asakiz @Aloso @Jonathas-Conceicao