Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to filter ArchiveIterator entries #109

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Allow to filter ArchiveIterator entries #109

merged 2 commits into from
Mar 21, 2023

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Mar 20, 2023

Add the ability to filter entries of an ArchiveIterator to skip unwanted archive entries and skip their decompression. To avoid introducing more constructor functions of ArchiveIterator, currently from_read_with_encoding() and from_read(), add a factory pattern via ArchiveIteratorBuilder.

Closes: #72

@otavio
Copy link
Member

otavio commented Mar 20, 2023

Can you rebase and check the CI error?

@coveralls
Copy link

coveralls commented Mar 20, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4480796779

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.0%) to 84.328%
Files with Coverage Reduction New Missed Lines %
../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.27/src/mpsc/mod.rs 1 90.97%
../../../.cargo/registry/src/index.crates.io-6f17d22bba15001f/futures-channel-0.3.27/src/mpsc/sink_impl.rs 3 76.92%
Totals Coverage Status
Change from base Build 4473309092: -1.0%
Covered Lines: 339
Relevant Lines: 402
💛 - Coveralls

@cgzones
Allow to filter ArchiveIterator entries
59ea897 
Add the ability to filter entries of an `ArchiveIterator` to skip
unwanted archive entries and skip their decompression.
To avoid introducing more constructor functions of `ArchiveIterator`,
currently `from_read_with_encoding()` and `from_read()`, add a factory
pattern via `ArchiveIteratorBuilder`.

Closes: OSSystems#72
@otavio otavio merged commit 718c064 into OSSystems:master Mar 21, 2023
@cgzones cgzones deleted the filter branch March 21, 2023 16:03
@Morganamilo Morganamilo mentioned this pull request Mar 19, 2024
Closed
@coveralls
Copy link

coveralls commented Sep 8, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 4480503493

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.323%
Totals Coverage Status
Change from base Build 4473309092: 0.0%
Covered Lines: 343
Relevant Lines: 402
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Iterate archive without reading all data.
3 participants
@cgzones @otavio @coveralls