-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fatal runtime error: stack overflow when try use ArchiveIteratorBuilder.filter() #113
fix: fatal runtime error: stack overflow when try use ArchiveIteratorBuilder.filter() #113
Conversation
1026da3
to
0f12c41
Compare
I noticed that the formatting error in the code has been fixed. I have sent a revised code for your review in the branch. Additionally, it would be great if you could add an item to the CHANGES.md file to document the change. |
@otavio I will again correct the problems that occurred in the actions and a doubt I have is where can I add this change in "CHANGES.md", would it be below the "## [Unreleased] - ReleaseDate" right? |
Yes, it'll be below it. |
No worries, I am happy to help :-) |
d53f875
to
dfcfb8b
Compare
Signed-off-by: Otavio Salvador <[email protected]>
dfcfb8b
to
8920853
Compare
I did minor changes and squashed the commits. |
Released 0.14.2. |
Pull Request Test Coverage Report for Build 5051902929Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 5051536844Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
problem
When trying to use the "filter" function of ArchiveIteratorBuilder in "rar/zip/7z" with large amounts of files
( in my case 24 thousand )
and implement some rule in the "filter", the program ends up breaking if it doesn't "match" during thousands of files traversed, because if the "filter" does not "match" during each chunk, it calls "self.next()" again recursively to process the next chunk/header, thus filling the call stack and causing a "fatal runtime error".solution
I removed the recursion and added a loop.