fix: use slice::from_raw_parts only if size > 0 #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbehr1
force-pushed
the
fix/unsafe_precond_warning
branch
from
fe31d24
to
462203c
Compare
libarchive seems to pass a nullptr with size 0 to the archive_read_data_block callback. This leads to a precondition violated assert in debug builds.
otavio
force-pushed
the
fix/unsafe_precond_warning
branch
from
462203c
to
3f268b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libarchive seems to pass a nullptr with size 0 to the archive_read_data_block callback. This leads to a precondition violated assert in debug builds.