More generic read/write api #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2020 10:00
Signed-off-by: Jonathas-Conceicao <[email protected]>
Require just `Read` and `Write` for input arguments and drop the `'static` requirement for `Read`. Signed-off-by: Jonathas-Conceicao <[email protected]>
Pull Request Test Coverage Report for Build c65cc49703a70b6bf6baa0f04e8d1e39e705cdd1-PR-14
💛 - Coveralls |
otavio
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require just
ReadandWritefor input arguments and drop the'staticrequirement forRead.This allows, for one, the use of slices as write targets for
uncompress_file, a (doc) test as been added for it to avoid regression bugs.This should not be a breaking change since we have that
impl<'_, W: Write + ?Sized> Write for &'_ mut Wandimpl<'_, R: Read + ?Sized> Read for &'_ mut R.