Fix error when uncompressing specific files from 7z archives #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 554607987Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
otavio
requested changes
Feb 10, 2021
otavio
force-pushed
the
topic/issue-46
branch
4 times, most recently
from
8652b29
to
22fb769
Compare
otavio
approved these changes
Feb 10, 2021
|
@Asakiz the tests, on AArch64 and ARMv7 are failing. Could you take a look? |
We need libarchive 3.2.0 at least to properly support the 7z archive format, so we upgraded that on the validation Docker images used in cross. Signed-off-by: Otavio Salvador <[email protected]>
otavio
force-pushed
the
topic/issue-46
branch
from
22fb769
to
422b70d
Compare
|
@Asakiz I successfully fixed the CI tests. As you mentioned the minimal version we need is |
There are some archive formats which require the seeking support, such as 7z archives. This commit add support for the seeking of those archives, fixing 7z uncompressing. Fixes: #46. Signed-off-by: Otavio Salvador <[email protected]> Signed-off-by: asakiz <[email protected]>
otavio
force-pushed
the
topic/issue-46
branch
from
422b70d
to
6ecea2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests: Add a test case for
uncompress_archive_fileusing 7z fileSigned-off-by: Otavio Salvador [email protected]
Signed-off-by: asakiz [email protected]