Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid display attribute causing build error #58

Merged
merged 1 commit into from
May 21, 2021
Merged

Fix invalid display attribute causing build error #58

merged 1 commit into from
May 21, 2021

Conversation

innobead
Copy link
Contributor

From derive_more 0.99.4, the invalid display attribute meta will be
marked as an error and returned.

ref: JelteF/derive_more@a5d00057

Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add an entry on CHANGES.md?

@coveralls
Copy link

coveralls commented May 20, 2021

Pull Request Test Coverage Report for Build 859898243

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 85.372%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/error.rs 0 3 0.0%
Totals Coverage Status
Change from base Build 810993774: 0.07%
Covered Lines: 321
Relevant Lines: 376

💛 - Coveralls

From derive_more 0.99.4, the invalid display attribute meta will be
marked as an error and returned.

ref: JelteF/derive_more@a5d00057
@innobead
Copy link
Contributor Author

Could you add an entry on CHANGES.md?

Done

@otavio otavio merged commit 9c0f4cb into OSSystems:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants