Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework the api #6

Merged
merged 1 commit into from
Apr 13, 2020
Merged

rework the api #6

merged 1 commit into from
Apr 13, 2020

Conversation

Asakiz
Copy link
Contributor

@Asakiz Asakiz commented Mar 12, 2020 •
edited
Loading

  • fix the lzip file;
  • add uncompress_archive func;
  • add uncompress_archive_file func;
  • add uncompres_archive_file func;
  • add integration tests;
  • add error enum;
  • add a binding script generator;
  • rework the example;

Signed-off-by: asakiz [email protected]

otavio
otavio requested changes Mar 12, 2020
View reviewed changes
src/build.rs Outdated Show resolved Hide resolved
binding_script.rs Show resolved Hide resolved
src/build.rs Show resolved Hide resolved
otavio
otavio requested changes Mar 13, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio requested changes Mar 16, 2020
View reviewed changes
src/util.rs Outdated Show resolved Hide resolved
Jonathas-Conceicao
Jonathas-Conceicao requested changes Mar 19, 2020
View reviewed changes
src/build.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/util.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@Asakiz Asakiz requested a review from otavio March 19, 2020 13:51
otavio
otavio requested changes Mar 19, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio requested changes Mar 19, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
Jonathas-Conceicao
Jonathas-Conceicao requested changes Mar 19, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
otavio
otavio requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash all changes in a single commit.

src/error.rs Outdated Show resolved Hide resolved
Jonathas-Conceicao
Jonathas-Conceicao requested changes Apr 7, 2020
View reviewed changes
Copy link
Member

@Jonathas-Conceicao Jonathas-Conceicao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left requests for some tweeks and a reminder for the example that is incomplete.

Also, would be nice if you could rework the commits for a more meaningful git history.

src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio requested changes Apr 8, 2020
View reviewed changes
src/error.rs Outdated Show resolved Hide resolved
src/error.rs Show resolved Hide resolved
otavio
otavio reviewed Apr 8, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
otavio
otavio reviewed Apr 8, 2020
View reviewed changes
src/error.rs Outdated Show resolved Hide resolved
Jonathas-Conceicao
Jonathas-Conceicao requested changes Apr 8, 2020
View reviewed changes
src/error.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio reviewed Apr 8, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio reviewed Apr 8, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio requested changes Apr 13, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio reviewed Apr 13, 2020
View reviewed changes
src/lib.rs Show resolved Hide resolved
otavio
otavio reviewed Apr 13, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
otavio
otavio reviewed Apr 13, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
Jonathas-Conceicao
Jonathas-Conceicao reviewed Apr 13, 2020
View reviewed changes
src/lib.rs Outdated Show resolved Hide resolved
@Asakiz
Rework the api now using libarchive, instead of shell
e05f7e1 
- fix the lzip file;
- add uncompress_archive func;
- add uncompress_archive_file func;
- add uncompres_archive_file func;
- add integration tests;
- rework error enum;
- add a binding script generator;
- rework the example;

Signed-off-by: asakiz <[email protected]>
@otavio otavio merged commit c433259 into OSSystems:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otavio otavio otavio requested changes

@Jonathas-Conceicao Jonathas-Conceicao Jonathas-Conceicao requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Asakiz @otavio @Jonathas-Conceicao