Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unnecessary lifetime annotations #90

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Conversation

cgzones
Copy link
Contributor

@cgzones cgzones commented Oct 26, 2022

The 'static lifetime annotations on ArchiveIterator::read_from() hinder the usage on non-local variables, e.g. a given slice of bytes wrapped in std::core::Cursor.

@coveralls
Copy link

coveralls commented Oct 26, 2022

Pull Request Test Coverage Report for Build 3331068154

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 28 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-5.7%) to 80.142%

Files with Coverage Reduction New Missed Lines %
src/lib.rs 28 51.16%
Totals Coverage Status
Change from base Build 3331054503: -5.7%
Covered Lines: 339
Relevant Lines: 423

💛 - Coveralls

Copy link
Member

@otavio otavio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • rebase on top of master
  • add an entry to CHANGES.md
  • fix formatting and force-push

The 'static lifetime annotations on ArchiveIterator::read_from() hinder
the usage on non-local variables, e.g. a given slice of bytes wrapped in
std::core::Cursor.
@otavio otavio merged commit a87ce26 into OSSystems:master Oct 26, 2022
@cgzones cgzones deleted the lifetime branch October 26, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants