-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Increase buffer size #93
Conversation
Pull Request Test Coverage Report for Build 3430997973Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Did you compare the memory use? This might impact embedded devices, hence my question. |
time(1) shows |
Can you add an entry on CHANGES file before merging? |
Tested against cov-analysis-linux64-2022.06.tar.gz (1.2G) with /tmp mounted on a tmpfs: $ hyperfine -w 1 -m 10 -c 'rm -Rf /tmp/benchtest/*' './target/release/examples/uncompress_tool uncompress-archive cov-analysis-linux64-2022.06.tar.gz /tmp/benchtest true' Benchmark 1: ./target/release/examples/uncompress_tool uncompress-archive cov-analysis-linux64-2022.06.tar.gz /tmp/benchtest true Time (mean ± σ): 9.516 s ± 0.053 s [User: 7.088 s, System: 2.401 s] Range (min … max): 9.462 s … 9.626 s 10 runs $ hyperfine -w 1 -m 10 -c 'rm -Rf /tmp/benchtest/*' './target/release/examples/uncompress_tool uncompress-archive cov-analysis-linux64-2022.06.tar.gz /tmp/benchtest true' Benchmark 1: ./target/release/examples/uncompress_tool uncompress-archive cov-analysis-linux64-2022.06.tar.gz /tmp/benchtest true Time (mean ± σ): 8.055 s ± 0.027 s [User: 6.386 s, System: 1.643 s] Range (min … max): 8.008 s … 8.085 s 10 runs
We might need to raise the MSRV due to Darwin. Are you aware of any possible cause of this error? |
Also check for updates for GitHub actions.
Signed-off-by: Otavio Salvador <[email protected]>
Pull Request Test Coverage Report for Build 3431009596Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Tested against cov-analysis-linux64-2022.06.tar.gz (1.2G) with /tmp mounted on a tmpfs: