Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add illumos compilation support #99

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

Toasterson
Copy link
Contributor

@coveralls
Copy link

coveralls commented Jan 7, 2023

Pull Request Test Coverage Report for Build 3863964546

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.557%

Totals Coverage Status
Change from base Build 3505825334: 0.0%
Covered Lines: 334
Relevant Lines: 395

💛 - Coveralls

@otavio
Copy link
Member

otavio commented Jan 7, 2023

@Toasterson any idea why this broke MacOS?

@Toasterson
Copy link
Contributor Author

I had that error on a couple systems aswell. pkg-config can't find iconv.

Seems to have been going on for a while when I look into the CI.

mabe brew install iconv helps

 --- stderr
  thread 'main' panicked at 'Unable to find libarchive: `PKG_CONFIG_ALLOW_SYSTEM_CFLAGS="1" PKG_CONFIG_ALLOW_SYSTEM_LIBS="1" PKG_CONFIG_PATH="/usr/local/Cellar/libarchive/3.6.2/lib/pkgconfig" "pkg-config" "--libs" "--cflags" "libarchive" "libarchive >= 3.2.0"` did not exit successfully: exit status: 1
  error: could not find system library 'libarchive' required by the 'compress-tools' crate

  --- stderr
  Package iconv was not found in the pkg-config search path.
  Perhaps you should add the directory containing `iconv.pc'
  to the PKG_CONFIG_PATH environment variable
  Package 'iconv', required by 'libarchive', not found
  ', src/build.rs:14:10
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

@otavio otavio merged commit e0db73d into OSSystems:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants