Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Julia v1.10 + CairoMakie v0.11 #166

Merged
merged 17 commits into from
Mar 12, 2024
Merged

Use Julia v1.10 + CairoMakie v0.11 #166

merged 17 commits into from
Mar 12, 2024

Conversation

navidcy
Copy link
Collaborator

@navidcy navidcy commented Jan 22, 2024

use Julia v1.10 for CI and docs

also uses CairoMakie v0.11 and updates Figure(resolution=...) to Figure(size=...).

@navidcy
Copy link
Collaborator Author

navidcy commented Jan 23, 2024

Actually we should better wait for CliMA/Oceananigans.jl#3403

@navidcy navidcy changed the title Use Julia v1.10 Use Julia v1.10 + CairoMakie v0.11 Feb 1, 2024
@navidcy navidcy requested a review from jagoosw February 1, 2024 10:28
@jagoosw
Copy link
Collaborator

jagoosw commented Feb 1, 2024

Should we attempt to get rid of all of the @unrolls that are giving warnings

@navidcy
Copy link
Collaborator Author

navidcy commented Feb 2, 2024

I removed a few. The rest are in Oceananigans and CliMA/Oceananigans.jl#3403 should clear them up.

@@ -27,7 +27,7 @@
end

# the rest of the points
@unroll for k in grid.Nz-1:-1:1
for k in grid.Nz-1:-1:1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navidcy for e.g. this @unroll, do we have any idea how much time it would save to have it work? Because here (for example) we could give the function Nz in some way that it knows it at compile time, but the extra obfuscation in the code wouldn't be worth it if its not a great time saving

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea but you can try and bench?

@navidcy
Copy link
Collaborator Author

navidcy commented Feb 28, 2024

I think we are ready for this PR since CliMA/Oceananigans.jl#3403 was merged.

@navidcy navidcy requested a review from jagoosw February 28, 2024 13:40
@jagoosw
Copy link
Collaborator

jagoosw commented Mar 6, 2024

Sorry for the slow response to this. Does the current version of Oceananigans have some warnings left like in the tests or are they coming from OceanBioME?

@navidcy
Copy link
Collaborator Author

navidcy commented Mar 6, 2024

We need to retrigger the tests so they use v0.90.9

@jagoosw
Copy link
Collaborator

jagoosw commented Mar 11, 2024

I restarted them now

@navidcy
Copy link
Collaborator Author

navidcy commented Mar 11, 2024

I don't understand why the CI has trouble installing Oceananigans v0.90.10

Also, what triggers this warning?

https://buildkite.com/oceanbiome/oceanbiome/builds/134#018e2e08-1b82-42e2-8aa9-5a627152001d/25-28

@navidcy
Copy link
Collaborator Author

navidcy commented Mar 11, 2024

@jagoosw
Copy link
Collaborator

jagoosw commented Mar 11, 2024

I see you've resolved it now but I am also having trouble compiling 0.90.10 locally, when I update my julia to 1.10 it is resolved but might be something I should mention on the other repo.

I'll try and work out whats going on with that test now.

@navidcy
Copy link
Collaborator Author

navidcy commented Mar 12, 2024

I think this is ready to go. I updated to Oceananigansv v0.90.11 that removed some of the unroll-related warnings that had sneaked in by accident. @jagoosw?

@jagoosw
Copy link
Collaborator

jagoosw commented Mar 12, 2024

Great, thank you for sorting this!

Copy link
Collaborator

@jagoosw jagoosw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@navidcy navidcy merged commit 8977314 into main Mar 12, 2024
5 checks passed
@navidcy navidcy deleted the ncc/julia-v-1-10 branch March 12, 2024 14:37
navidcy added a commit that referenced this pull request Mar 25, 2024
bumping up a patch release so that we don't get warnings for deprecated Oceananigans method `arch_array`

x-ref #166
@navidcy navidcy mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants