[User Model] Make sdkVersion
in OneSignalWrapper settable.
#1733
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Allow
OneSignalWrapper.sdkVersion
to be set.Details
Motivation
OneSignalWrapper.sdkVersion
is designed to be set by a wrapper SDK. It was accidentally defined as aval
which is readonly. This fix updates thesdkVersion
field to be read/write by making it avar
.Testing
Manual testing
Confirmed
OneSignalWrapper.sdkVersion
can be set by users of the Android SDK in local development environment.Affected code checklist
Checklist
Overview
Testing
Final pass
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)