Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User Model] Make sdkVersion in OneSignalWrapper settable. #1733

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

brismithers
Copy link
Contributor

@brismithers brismithers commented Feb 3, 2023

Description

One Line Summary

Allow OneSignalWrapper.sdkVersion to be set.

Details

Motivation

OneSignalWrapper.sdkVersion is designed to be set by a wrapper SDK. It was accidentally defined as a val which is readonly. This fix updates the sdkVersion field to be read/write by making it a var.

Testing

Manual testing

ConfirmedOneSignalWrapper.sdkVersion can be set by users of the Android SDK in local development environment.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

Copy link
Contributor

@shepherd-l shepherd-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brismithers)

@brismithers brismithers merged commit 8499e90 into user-model/main Feb 16, 2023
@brismithers brismithers deleted the user-model/wrapper-sdkversion-settable branch February 16, 2023 19:55
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…-settable

[User Model] Make `sdkVersion` in OneSignalWrapper settable.
jinliu9508 pushed a commit that referenced this pull request Jan 31, 2024
…-settable

[User Model] Make `sdkVersion` in OneSignalWrapper settable.
jinliu9508 pushed a commit that referenced this pull request Feb 6, 2024
…-settable

[User Model] Make `sdkVersion` in OneSignalWrapper settable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants