Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[csharp] massively improve csharp templates code #18885

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

filipe-silva
Copy link
Contributor

@filipe-silva filipe-silva commented Jun 9, 2024

massively improve csharp templates code

improved apiclient.mustache to keep it dry, sharing a single exec with Action<> delegate.
improved api.mustache to keep it dry, used chain constructors, kept RequestOptions in a single method, set configuration with alias directive
moved fqn types to using directive for cleaner code
removed 'this' from variables/props that are redundant
fix CSharpClientDeepObjectTest code is now DRY so count must only be one

Note:
This is a PR based on #16990 with resolved merge conflicts, and up to date with master

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha @wing328

improved apiclient.mustache to keep it dry, sharing a single exec with Action<> delegate.
improved api.mustache to keep it dry, used chain constructors, kept RequestOptions in a single method, set configuration with alias directive
moved fqn types to using directive for cleaner code
removed 'this' from variables/props that are redundant
fix CSharpClientDeepObjectTest code is now DRY so count must only be one
@wing328
Copy link
Member

wing328 commented Jun 9, 2024

please PM me via Slack when you've time. thanks

@devhl-labs
Copy link
Contributor

devhl-labs commented Jun 9, 2024

Your additions to ApiClient.mustache use tabs. The rest of the document and all the other mustache templates use spaces. This is a regular comment instead of a review because my browser tends to freeze looking at large diffs :(

Tabs in some other places too. I recommend you turn on whitespace in your editor. If you're using vscode I've noticed you have to toggle the whitespace option to get them to show.

@wing328
Copy link
Member

wing328 commented Jun 10, 2024

Please instead submit a small PR for each enhancement or bug fix so that it can be reviewed and merged more easily.

@wing328
Copy link
Member

wing328 commented Jun 10, 2024

and looks like some of these enhancements were already done in the latest master. e.g. https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/main/resources/csharp/modelGeneric.mustache#L401

my suggestion is to file new smaller PRs based on the latest master and we can get these merged quicker to keep the ball rolling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants