-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dart): dart-next generator #18970
base: master
Are you sure you want to change the base?
Conversation
cc core team: @wing328 @jimschubert @cbornet @jmini @etherealjoy I made a non-breaking change in DefaultCodegen by adding a new method public void updateCodegenPropertyEnum(CodegenProperty var, CodegenModel model) |
cc dart committee for early review: |
supersedes #15485
This generator is designed to replace both
dart
anddart-dio
generators, and has the following features:dart run build_runner build
).UndefinedWrapper<T>
which makes any non-required variable recognizeundefined
as a valid value, in which case, it will NOT be included during serialization.NetworkingClientBase
package:http
, butpackage:dio
can be added as wellshared_infrastructure
package that has simple base models that should NOT be changed, but the generator will also include an option to inline it. this is done so we can maintain a version of it on pub.dev which users can opt-in to use.package:cross_file
to handle filesCurrent tasks:
P.S. testing and templating for this generator is done here https://github.com/ahmednfwela/dart-next-generator-testing
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master
(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x
(breaking changes without fallbacks)