Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultServer name change feature #331

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

kabicin
Copy link
Member

@kabicin kabicin commented Aug 9, 2022

Fixes #284

Changes:

  • Leverages SERVER_NAME environment variable utilized by server script during Liberty server create. However, this incurs some latency to the server start as a new server must be generated at runtime.
  • Creates double symlink to /output and /config so intermediate symlinks can be managed at build time by default user.

@kabicin kabicin marked this pull request as draft August 9, 2022 20:22
@kabicin kabicin marked this pull request as ready for review August 15, 2022 18:38
@kabicin kabicin requested a review from leochr August 15, 2022 18:38
@kabicin kabicin force-pushed the kirby-patch-defaultServerChange branch from d852181 to 5f79179 Compare September 6, 2022 18:00
@kabicin kabicin marked this pull request as draft January 23, 2023 19:00
@kabicin kabicin force-pushed the kirby-patch-defaultServerChange branch 2 times, most recently from adf1957 to 2178608 Compare June 2, 2023 15:26
@kabicin kabicin marked this pull request as ready for review June 13, 2023 20:38
@kabicin kabicin force-pushed the kirby-patch-defaultServerChange branch from 8e06287 to 1fb52e6 Compare July 10, 2023 14:29
@kabicin kabicin self-assigned this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support configuration of server name
1 participant