Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flock() instead of UUCP-style locking for serial devices #1770

Open
wants to merge 44 commits into
base: master
Choose a base branch
from
Open

Use flock() instead of UUCP-style locking for serial devices #1770

wants to merge 44 commits into from

Commits on Feb 7, 2022

  1. Use flock() instead of UUCP-style locking for serial devices 

    This replaces AcquireUUCPLockAndOpen() with AcquireLockAndOpen().
Depending on a compile-time option (--enable-uucp-locking), either
flock() or UUCP-style lockfiles will be used as the underlying lock
mechanism.  The default is flock().

The plugins using these routines have been updated.
    @taw10
    taw10 committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    b142600 View commit details
    Browse the repository at this point in the history

  2. Ignore a codespell false positive due to line wrapping

    @peternewman
    peternewman committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    0556472 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2022

  1. Always compile UUCP code 

    There's not much to be gained from not compiling it.
    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    dd34c1d View commit details
    Browse the repository at this point in the history

  2. Rename UUCP lock routines 

    RemoveLockFile -> RemoveUUCPLockFile
GetLockFile -> GetUUCPLockFile
    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    cf4be90 View commit details
    Browse the repository at this point in the history

  3. Rename AcquireLockAndOpen -> AcquireLockAndOpenSerialPort

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    638daf7 View commit details
    Browse the repository at this point in the history

  4. Add ReleaseSerialPortLock (to match AcquireLockAndOpenSerialPort)

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    5d0cb39 View commit details
    Browse the repository at this point in the history

  5. Fix indentation

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    15a299b View commit details
    Browse the repository at this point in the history

  6. OpenAndFlock: Return false if flock() is not available

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    10e4ac6 View commit details
    Browse the repository at this point in the history

  7. Add a message when locking with flock()

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    d195639 View commit details
    Browse the repository at this point in the history

  8. Restore documentation of deprecated UUCP locking routines

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    ce8f9b4 View commit details
    Browse the repository at this point in the history

  9. OpenAndFlock: close FD if flock() is not available

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    d9f2721 View commit details
    Browse the repository at this point in the history

  10. Add extra spaces before comments

    @taw10
    taw10 committed Feb 13, 2022
    Configuration menu
    Copy the full SHA
    4ea7de4 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2022

  1. Wrap a long line 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    6951d76 View commit details
    Browse the repository at this point in the history

  2. Add some more debug messages

    @taw10
    taw10 committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    61752ab View commit details
    Browse the repository at this point in the history

  3. Add deprecation dates

    @taw10
    taw10 committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    d45704f View commit details
    Browse the repository at this point in the history

  4. Add parentheses to make Doxygen link a reference

    @taw10
    taw10 committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    53b8c2c View commit details
    Browse the repository at this point in the history

  5. Add SerialLockTester

    @taw10
    taw10 committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    9cd59a8 View commit details
    Browse the repository at this point in the history

  6. Don't fail if TIOCEXCL doesn't work

    @taw10
    taw10 committed Feb 19, 2022
    Configuration menu
    Copy the full SHA
    3e072f1 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2022

  1. SerialLockTester: formatting fixes

    @taw10
    taw10 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    4bcf0f6 View commit details
    Browse the repository at this point in the history

  2. SerialLockTester: rearrange includes

    @taw10
    taw10 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    d035bde View commit details
    Browse the repository at this point in the history

  3. SerialLockTester: Rearrange includes again

    @taw10
    taw10 committed Feb 20, 2022
    Configuration menu
    Copy the full SHA
    379db11 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2022

  1. SerialLockTester: Create the test file

    @taw10
    taw10 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    662b6e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. Update include/ola/io/Serial.h 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    b394083 View commit details
    Browse the repository at this point in the history

  2. Remove pre-processor comment 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    8ca5f34 View commit details
    Browse the repository at this point in the history

  3. Mention flock() when saying "No unlock necessary" 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    11b2f40 View commit details
    Browse the repository at this point in the history

  4. Update include/ola/io/Serial.h 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    ff04282 View commit details
    Browse the repository at this point in the history

  5. Update common/io/SerialLockTester.cpp 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    6138823 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. Fix debug message and over-long line

    @taw10
    taw10 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    3d9ae1d View commit details
    Browse the repository at this point in the history

  2. SerialLockTester: Eliminate unused variable

    @taw10
    taw10 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    7fe0fa5 View commit details
    Browse the repository at this point in the history

  3. Split serial port locking into three separate steps 

    UUCP locking: performed if requested at configure time
flock(): performed if the flock call is available (always?)
ioctl(fd, TIOCEXCL): performed if sys/ioctl.h is available

It's possible that all three will be done, but only one of them really
has to work.  If any of the selected methods fail, however, the port
opening will be aborted.
    @taw10
    taw10 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    f9dec96 View commit details
    Browse the repository at this point in the history

  4. Formatting

    @taw10
    taw10 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    0bfe200 View commit details
    Browse the repository at this point in the history

  5. Fix include order

    @taw10
    taw10 committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    9fe41fe View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2022

  1. Clarify info message about TIOCEXCL 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    f60bd33 View commit details
    Browse the repository at this point in the history

  2. Restore deleted comment 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    4806d31 View commit details
    Browse the repository at this point in the history

  3. Add explanatory comment to #endif 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    0dfa3f9 View commit details
    Browse the repository at this point in the history

  4. SerialLockTester: Add ".pid" to test filename 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    f97bc8d View commit details
    Browse the repository at this point in the history

  5. Update comments about serial port locking

    @taw10
    taw10 committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    a528123 View commit details
    Browse the repository at this point in the history

  6. Fix ordering of RemoveUUCPLockFile() and close()

    @taw10
    taw10 committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    98d4b66 View commit details
    Browse the repository at this point in the history

  7. Add more #endif comments

    @taw10
    taw10 committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    64d4943 View commit details
    Browse the repository at this point in the history

  8. AcquireLockAndOpenSerialPort: Release UUCP lock on error paths

    @taw10
    taw10 committed Mar 20, 2022
    Configuration menu
    Copy the full SHA
    3ada1bd View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Merge branch 'master' into serial-flock

    @taw10
    taw10 committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    277e151 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2022

  1. Apply suggestions from code review 

    Co-authored-by: Peter Newman <[email protected]>
    @taw10 @peternewman
    taw10 and peternewman committed Nov 13, 2022
    Configuration menu
    Copy the full SHA
    227a613 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. Merge branch 'master' into serial-flock

    @taw10
    taw10 committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    185b881 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2023

  1. Merge branch 'master' into serial-flock

    @taw10
    taw10 committed Oct 28, 2023
    Configuration menu
    Copy the full SHA
    a93bde9 View commit details
    Browse the repository at this point in the history