Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codespell typo in RDMCommand #1857

Conversation

DaAwesomeP
Copy link
Member

No description provided.

@peternewman peternewman added this to the 0.11.0 milestone Apr 30, 2023
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DaAwesomeP however please can you do a version of this targeting 0.10 too as that will still be complaining as well.

@DaAwesomeP
Copy link
Member Author

Ah sorry, yes. I always forget to check that. Should I make a new pull or change the target of this one?

@peternewman
Copy link
Member

Whichever you fancy. If it gets into 0.10 we can resync from there into master.

@DaAwesomeP DaAwesomeP changed the base branch from master to 0.10 May 1, 2023 17:01
@DaAwesomeP DaAwesomeP force-pushed the DaAwesomeP-fix-codespell-typo2 branch from d54a399 to c8468bd Compare May 1, 2023 17:01
@DaAwesomeP
Copy link
Member Author

@peternewman rebased!

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@peternewman peternewman merged commit b6900db into OpenLightingProject:0.10 May 1, 2023
@peternewman peternewman modified the milestones: 0.11.0, 0.10.10 May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants