Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facilitator init optimization and bug fixes #242

Merged
merged 6 commits into from
Oct 24, 2019
Merged

Facilitator init optimization and bug fixes #242

merged 6 commits into from
Oct 24, 2019

Conversation

gulshanvasnani
Copy link
Contributor

@gulshanvasnani gulshanvasnani commented Oct 23, 2019 •
edited
Loading

PR contains below optimization for facilitator init :

  1. Changed datatype of auxchain id from string to number consistent.
  2. Changed datatype of auxchain id in faciltiator-schema to number.
  3. Updated test-cases to reflect the change.
  4. Loading of gatewayconfig when gateway config option is specified.

fixes #212

@0xsarvesh
Copy link
Contributor

Could you please specify in the PR description about bug and optimisation you have done.

@gulshanvasnani
Copy link
Contributor Author

Could you please specify in the PR description about bug and optimisation you have done.

I have now specified the changes done on PR.

@abhayks1 abhayks1 self-assigned this Oct 24, 2019
abhayks1
abhayks1 suggested changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

test_integration/05_facilitator_stop/01_stop.test.ts Outdated Show resolved Hide resolved
test/FacilitatorConfig/remove.test.ts Outdated Show resolved Hide resolved
test/Database/create.test.ts Outdated Show resolved Hide resolved
src/bin/facilitator-init.ts Show resolved Hide resolved
@abhayks1 abhayks1 removed their assignment Oct 24, 2019
abhayks1
abhayks1 approved these changes Oct 24, 2019
View reviewed changes
Copy link
Contributor

@abhayks1 abhayks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@abhayks1 abhayks1 merged commit 35df9a4 into OpenST:master Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhayks1 abhayks1 abhayks1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facilitator init & start compatibility for Gateway Config
3 participants
@gulshanvasnani @0xsarvesh @abhayks1