-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/not_loading_without_key #15
Conversation
To close 14 we should additionally add DEFAULT_SETTINGS = {...}
def initialize(self):
self.settings.merge(DEFAULT_SETTINGS, new_only=True)
self.settings.store()
... |
why? there are no default settings, users need to get a key the file gets created already with |
thought of a more fleshy config. Nevertheless, i like the key(s) to be set as a rule of thumb, waiting for values to be filled. |
id like self.chat to continue throwing an exception if key is not set, but for sure we can make that more informative than it already is with some LOGs let's do that in another PR and keep this one just as a bugfix |
Tested this, however fails with the below log snippet;
|
those seem to be logs without this PR applied? |
Will double check and report back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-tested and all fine. Good to merge
closes #14