Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the gpt model has no context #27

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

PocketMiner82
Copy link

@PocketMiner82 PocketMiner82 commented Aug 9, 2024

ChatGPT had no context because the qa_pairs were given to self.chat which resets itself every time it is called. Additionally, the questions and answers were mixed up.

Summary by CodeRabbit

  • Bug Fixes
    • Improved logic for saving question-answer pairs to enhance data integrity by preventing the addition of incomplete interactions.
  • Refactor
    • Streamlined access to the chat variable for better code readability and potential performance improvements.
  • Enhancements
    • Updated logging to provide better insights into chat state after message history is built.

Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

The recent changes enhance the logic in the chat session management, focusing on improved data integrity and code readability. Modifications in the build_msg_history method ensure that only complete question-answer pairs are saved, while the _async_ask method refines attribute access for clarity and performance. Overall, these updates contribute to a more robust and maintainable codebase, providing better logging insights into the chat's state.

Changes

Files Change Summary
__init__.py Improved logic in build_msg_history to prevent saving incomplete pairs. Refactored _async_ask for better attribute access and enhanced logging.

Poem

In the burrow deep where the code doth dwell,
A lovely change rang out, oh what a swell!
With messages tidy, and logic so bright,
Our chat hops forward, a joyous delight!
So here's to the tweaks that make our hearts sing,
A rabbit's cheer for all change they bring! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1483bd9 and 59aa0f9.

Files selected for processing (1)
  • init.py (2 hunks)
Additional comments not posted (2)
__init__.py (2)

72-77: Improved data integrity in build_msg_history.

The conditional check ensures that only complete question-answer pairs are saved, enhancing data integrity and robustness.


91-93: Enhanced readability and logging in _async_ask.

Storing self.chat in a chat variable reduces repeated attribute access, improving readability. Logging chat.qa_pairs provides better insights into the chat state.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 59aa0f9 and ac9e28b.

Files selected for processing (1)
  • init.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • init.py

@goldyfruit goldyfruit added the enhancement New feature or request label Aug 9, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (dev@1483bd9). Learn more about missing BASE report.

Files Patch % Lines
__init__.py 0.00% 5 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #27   +/-   ##
======================================
  Coverage       ?   41.20%           
======================================
  Files          ?        4           
  Lines          ?      199           
  Branches       ?        0           
======================================
  Hits           ?       82           
  Misses         ?      117           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants