-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the gpt model has no context #27
base: dev
Are you sure you want to change the base?
Conversation
WalkthroughThe recent changes enhance the logic in the chat session management, focusing on improved data integrity and code readability. Modifications in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- init.py (2 hunks)
Additional comments not posted (2)
__init__.py (2)
72-77
: Improved data integrity inbuild_msg_history
.The conditional check ensures that only complete question-answer pairs are saved, enhancing data integrity and robustness.
91-93
: Enhanced readability and logging in_async_ask
.Storing
self.chat
in achat
variable reduces repeated attribute access, improving readability. Loggingchat.qa_pairs
provides better insights into the chat state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #27 +/- ##
======================================
Coverage ? 41.20%
======================================
Files ? 4
Lines ? 199
Branches ? 0
======================================
Hits ? 82
Misses ? 117
Partials ? 0 ☔ View full report in Codecov by Sentry. |
ChatGPT had no context because the qa_pairs were given to self.chat which resets itself every time it is called. Additionally, the questions and answers were mixed up.
Summary by CodeRabbit