Tax percentage calculation for Creditmemos without products #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Looking forward to your feedback after the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a Creditmemo does not contain any products, the generated debit request does not contain any tax percentage (va) for the shipping item.
The reason for this is, that the shipping and discount items get their va value from the first product's tax percentage. If none is set, the value remains false -> 0.
This Pull Request fixes this by falling back to reading the tax information from the order tax item table as a fallback, if the tax amount has not been initialized.
This is a draft, because we were not able to actually test it yet. I will report back when we successfully tested this in a customer installation.