Change GetUsersByPointTotals to fix caching bug #358

POPWorldMedia · Feb 1, 2024 · f73222f · f73222f
1 parent cd2e96a
commit f73222f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/src/PopForums.Sql/Repositories/UserRepository.cs b/src/PopForums.Sql/Repositories/UserRepository.cs
@@ -233,19 +233,19 @@ await _sqlObjectFactory.GetConnection().UsingAsync(connection =>
 		return list.Result.ToList();
 	}
 
-	public Dictionary<User, int> GetUsersByPointTotals(int top)
+	public Dictionary<int, (User, int)> GetUsersByPointTotals(int top)
 	{
 		var key = CacheKeys.PointTotals + top;
-		var cacheObject = _cacheHelper.GetCacheObject<Dictionary<User, int>>(key);
+		var cacheObject = _cacheHelper.GetCacheObject<Dictionary<int, (User, int)>>(key);
 		if (cacheObject != null)
 			return cacheObject;
-		var list = new Dictionary<User, int>();
+		var list = new Dictionary<int, (User, int)>();
 		_sqlObjectFactory.GetConnection().Using(connection =>
 			connection.Query<User, int, User>(
 				$"SELECT TOP {top} {PopForumsUserColumns}, pf_Profile.Points FROM pf_PopForumsUser JOIN pf_Profile ON pf_PopForumsUser.UserID = pf_Profile.UserID ORDER BY pf_Profile.Points DESC",
 				(user, points) =>
 				{
-					list.Add(user, points);
+					list.Add(user.UserID, (user, points));
 					return user;
 				}, splitOn: "Points"));
 		_cacheHelper.SetCacheObject(key, list, 60);

diff --git a/src/PopForums/Repositories/IUserRepository.cs b/src/PopForums/Repositories/IUserRepository.cs
@@ -91,7 +91,7 @@ public interface IUserRepository
 	Task DeleteUser(User user);
 	Task<List<User>> GetUsersFromIDs(IList<int> ids);
 	Task<int> GetTotalUsers();
-	Dictionary<User, int> GetUsersByPointTotals(int top);
+	Dictionary<int, (User, int)> GetUsersByPointTotals(int top);
 	Task<List<UserResult>> GetRecentUsers();
 	Task UpdateTokenExpiration(User user, DateTime? tokenExpiration);
 	Task UpdateRefreshToken(User user, string refreshToken);

diff --git a/src/PopForums/Services/UserService.cs b/src/PopForums/Services/UserService.cs
@@ -42,7 +42,7 @@ public interface IUserService
 	Task<List<User>> GetUsersFromIDs(IList<int> ids);
 	Task<int> GetTotalUsers();
 	Task<List<User>> GetSubscribedUsers();
-	Dictionary<User, int> GetUsersByPointTotals(int top);
+	Dictionary<int, (User, int)> GetUsersByPointTotals(int top);
 	Task<List<UserResult>> GetRecentUsers();
 	Task UpdateTokenExpiration(User user, DateTime? tokenExpiration);
 	Task UpdateRefreshToken(User user, string refreshToken);
@@ -529,7 +529,7 @@ public async Task<List<User>> GetSubscribedUsers()
 		return await _userRepository.GetSubscribedUsers();
 	}
 
-	public Dictionary<User, int> GetUsersByPointTotals(int top)
+	public Dictionary<int, (User, int)> GetUsersByPointTotals(int top)
 	{
 		return _userRepository.GetUsersByPointTotals(top);
 	}