added error handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Thanks so much for your contribution to Stockstir. I hadn't thought of adding error handling to the api class, I guess I had forgotten... silly mistake! :) Anyways, your pull request will most likely be merged after I test each error handling for each of those functions error handling were added to. Upon merging the pull request, would it be fine if I put your username under the contributors list in the README? Thanks again! |
PatzEdi
added a commit
that referenced
this pull request
Mar 31, 2024
|
Yup you can put my name in README |
|
Nice! Thanks so much for the contribution again. It has been merged, and the next release will include your contribution as credit. I am a bit new to contributing, so this has been a good learning experience. Happy coding! |
PatzEdi
added a commit
that referenced
this pull request
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added error handling in api.py