Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose an API or option so that it is possible to add custom keywords #45

Closed
hehoo opened this issue Feb 22, 2019 · 4 comments
Closed
Assignees

Comments

@hehoo
Copy link
Collaborator

hehoo commented Feb 22, 2019

It seems like this middleware didn't expose either an API or option that we are able to add custom keywords during the initialisation. Is it a good idea to add it on? See https://ajv.js.org/custom.html#define-keyword-with-validation-function for more info about custom keywords in ajv

@idanto
Copy link
Contributor

idanto commented Feb 22, 2019

This is a great idea! we would accept a PR with those additions 😃 @hehoo

@hehoo hehoo self-assigned this Feb 25, 2019
@hehoo
Copy link
Collaborator Author

hehoo commented Feb 25, 2019

@idanto do you have any documentation or design material that can make me quickly familiar with this whole project 😄 ?

@idanto
Copy link
Contributor

idanto commented Feb 26, 2019

@hehoo not really 🙈 Maybe we should write one, I always thought it's a small and simple project but since the koa and OpenAPI 3.0 support it kinda becomes bigger...

But in the meanwhile feel free to ask here any question you have or we can even use slack to communicate if you would like to

@idanto
Copy link
Contributor

idanto commented Mar 5, 2019

you can find this addition in version 0.9.0, thanks for the contribution @hehoo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants