Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extract api schema builder to other package #54

Merged
merged 33 commits into from
Apr 2, 2019
Merged

extract api schema builder to other package #54

merged 33 commits into from
Apr 2, 2019

Conversation

galcohen92
Copy link
Contributor

No description provided.

@galcohen92 galcohen92 changed the title Gal/master extract api schema builder to other package Mar 10, 2019
@coveralls
Copy link

coveralls commented Mar 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 99.074% when pulling 24a6379 on galcohen92:gal/master into 62ee749 on Zooz:master.

@galcohen92
Copy link
Contributor Author

galcohen92 commented Mar 10, 2019 •
edited
Loading

  1. InputValidaiton error refactor
  2. change parameters validator path, was under schemaEndpoint.parameters and now schemaEndpoint.parameters.validate
  3. api-schema-builder path : https://github.com/Zooz/api-schema-builder

idanto
idanto suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@idanto idanto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new api-schema-builder should move under Zooz org and needs to be reviewed as well

test/openapi3/openapi3-test.js Outdated Show resolved Hide resolved
src/inputValidationError.js Outdated Show resolved Hide resolved
src/inputValidationError.js Outdated Show resolved Hide resolved
@idanto idanto self-requested a review March 11, 2019 06:28
@galcohen92
Copy link
Contributor Author

  1. now the dependency api-schema-builder support request and responses validate. because the middleware only need requests validator it configure in the options for build requests only.

@idanto idanto mentioned this pull request Apr 1, 2019
Closed
idanto
idanto previously approved these changes Apr 1, 2019
View reviewed changes
@idanto
Copy link
Contributor

idanto commented Apr 1, 2019

@galcohen92 Please resolve the conflicts with master and also have a look at #59

idanto
idanto suggested changes Apr 1, 2019
View reviewed changes
test/pet-store-swagger-with-yaml-anchors.yaml Outdated Show resolved Hide resolved
test/pet-store-swagger.yaml Outdated Show resolved Hide resolved
test/pet-store-swagger-with-base-path.yaml Outdated Show resolved Hide resolved
test/pet-store-swagger-inheritance.yaml Outdated Show resolved Hide resolved
This was referenced Apr 2, 2019
Closed
Closed
@idanto idanto merged commit b31dbf5 into PayU:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idanto idanto idanto approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@galcohen92 @coveralls @idanto @galcohen11