Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accept RegExp as type of format.pattern #89

Merged
merged 2 commits into from
Aug 19, 2019
Merged

accept RegExp as type of format.pattern #89

merged 2 commits into from
Aug 19, 2019

Conversation

YoshiyukiKato
Copy link
Contributor

Thank you for creating nice lib!
I found a type checking error when specifying format by RegExp such as written in README. This PR will fix it.

@coveralls
Copy link

coveralls commented Aug 19, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.115% when pulling 55760bf on YoshiyukiKato:master into 4d37e34 on Zooz:master.

@kibertoad kibertoad merged commit 6f488b8 into PayU:master Aug 19, 2019
@kibertoad
Copy link
Collaborator

Thank you!

@idanto
Copy link
Contributor

idanto commented Aug 19, 2019

released in 1.0.5

Thanks @YoshiyukiKato

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YoshiyukiKato @coveralls @kibertoad @idanto