Upgrade viper to handle unmarshaling env into nested struct #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haoming29
added
bug
jhiemstrawisc
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1446
This PR upgraded viper to a pre-release version v1.20.0-alpha3 (came out this morning that fixes the issue), as they recently added this experimental support of handling unmarshaling env into nested struct via a viper option. They initially added support in v1.18.0 (spf13/viper#1429) but with some reported rare use case failure, they then did a patch to hide this feature behind a feature flag. In 1.20, they will make this available by config option (spf13/viper#1854).
If all tests are passing, I don't think there's anything that blocks us from using this pre-released version.
To test locally, follow bug reproduction in the original issue.