-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "breaking change" warning to build.jl #41
Comments
Thanks for this suggestion; I agree we can make this a bit less verbose going forward. Feel free to submit a PR with the suggested change! 😄 |
@david-macmahon this was fixed in principle by #42; feel free to reopen if it's not working as expected. |
Unfortunately, it's only a partial victory. The warning does not appear when I think it would be OK to revert this change (or decide to remove the warning altogether and/or move it to This warning is most problematic (if one can really call it a "problem") when using
|
Given that there has not been lots of complaints about moving on from telnet, I think it makes sense to move the warning to the README, so I'd propose to do just that. |
Can you confirm if the problem is solved in v0.4.8? |
Thanks, that's great! Yes, the problem is solved/eliminated in v0.4.8. While checking
...looks like... Warning Be careful! on GitHub and like |
Appreciate this change! |
@david-macmahon thank you for the suggestions! I went for adding the current release badge from JuliaHub, which will updated by itself in the future, and also added the GitHub-style markdown warning. I'll close this issue now (do let us know, though, if there's anything else needed to be done here). |
Fantastic! Looks great to me, thanks! |
Every time
HORIZONS
isimport
-ed orusing
-ed it prints a warning about a breaking change. This can be very distracting, especially in a notebook. I would like to suggest moving this warning todeps/build.jl
so that it is output only when the package is installed (or re-built viaPkg.build(")
).The text was updated successfully, but these errors were encountered: