-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update plugins from old plugin system to new plugin system #1078
Comments
👎 Passphrase: Github
|
👎 Deferred This plugin does: |
👎 Auth::Extensible: Github
|
👎 Auth::OAuth: Github |
👎 DBIC: Github
Due to this in the test: PR submitted ironcamel/Dancer2-Plugin-DBIC#13 Update: |
👎 Feed: Github |
👎 JWT: Github Two problems here. One was solved by using
That change is in the master branch of my fork: https://github.com/SysPete/Dancer2-Plugin-JWT Still leaves the |
👎 Redis: Github
|
👎 REST: Github Diff is pretty simple: remove
|
PerlDancer/Dancer2-Plugin-REST Using the new https://github.com/yanick/Dancer2-Plugin-REST/compare/master...PerlDancer:d2?expand=1 Using the 'sub foo :PluginKeyword` alternative does not trigger the warning. |
So we're waiting for D2P2 to be released before |
What @SysPete was tracking was how to make the most minimal changes to get the next version running without changing it to D2P2. Then it can be released already before D2P2 is released. |
On 2015-12-29 12:08 PM, Sawyer X wrote:
Sure. Will release the patch in a few minutes. |
@SysPete I fixed the uninitialized error! |
On 30/12/15 01:41, Sawyer X wrote:
|
Dancer2::Plugin::DBIC has been released with @SysPete's patch. |
On Wed, 30 Dec 2015, Stefan Hornburg (Racke) wrote:
... and on its way to the FreeBSD ports-tree :) |
Passphrase has been released on CPAN and is on its way to FreeBSD. |
Auth::Extensible @racke Is version 0.402 the one that is D2P2 ready? |
On 12/30/2015 01:49 PM, Henk van Oers wrote:
It doesn't have any special patches for D2P2, so it is uncertain. I'll check that. Regards Perl and Dancer Development Visit our Perl::Dancer conference 2015. |
It throws a lot of warnings:
|
For ProgressStatus, I have a branch that uses new style. I hadn't merged it yet but I can do that now |
Throwing warnings is on purpose. It's like that so you would have to upgrade. The warnings will only be thrown if someone uses an older version of the plugin (which uses the older D2::P plugin interface) while the new D2::P interface is available. This means that you release this version now - no warnings yet. We release a new version of Dancer2 with the new D2::P and then you have warnings until you upload a new version that uses the new interface. That's the deprecation cycle. Also, I pushed a fix for the last uninitialized error. |
Yes, sounds like a good plan. |
I've sent a short email to:
[ github will hopefully ping them a notification reminder too ;) /subtle ] |
@veryrusty I just published the updated DBIC and Email plugins to CPAN |
@ironcamel++ Thanks! 👯 |
@ironcamel Thanks for moving forward! |
Emailed authors of: HTTP::Auth::Extensible, Locale, Minify, Shutdown. |
I will make time tonight to fix this, and also look at the other D2::P::HTTP modules that I wrote.
|
@vanHoesel ❤️ |
Peter, with your changes, I run into trouble... running Failed test 'use Dancer2::Plugin::HTTP::Auth::Extensible;'at t/00-load.t line 6.Tried to use 'Dancer2::Plugin::HTTP::Auth::Extensible'.Error: syntax error at /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/blib/lib/Dancer2/Plugin/HTTP/Auth/Extensible.pm line 20, near "has default_realm”Or, doing Error: Can't locate Dancer2/Core/Types.pm in @inc (you may need to install the Dancer2::Core::Types module) (@inc contains: /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/lib /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/site_perl/5.18.4/darwin-2level /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/site_perl/5.18.4 /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/5.18.4/darwin-2level /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/5.18.4) at /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/lib/Dancer2/Plugin/HTTP/Auth/Extensible.pm line 7.$Dancer2::Core::Types::VERSION 0.166001 (just did a clean install for Dancer2::Plugin , which installs everything) Some advice is really welcome Theo
|
@vanHoesel apologies - I did not make it clear in PRs... The latest updates to your plugin will work ONLY with plugin2 which will be released as part of Dancer2 v0.200000 this weekend (assuming all goes well). For a small number of plugins (those that themselves use other plugins) it is not possible to be compatible with both current Dancer2 and also the next release. You can test against the latest DEV release: cpanm --dev Dancer2 |
For all who it may concern… doing a (clean) install for —dev Dancer2: ! Installing the dependencies failed: Module 'Type::Tiny' is not installed after installing that: [App::Basic:5341] error @2016-05-27 12:39:26> Route exception: Can't locate object method "_parse_query" via package "Dancer2::Core::Request" at /Users/tvanhoesel/.cpanm/work/1464349136.4981/Dancer2-0.166001_03/blib/lib/Dancer2/Core/Request.pm line 349. in /Users/tvanhoesel/.cpanm/work/1464349136.4981/Dancer2-0.166001_03/blib/lib/Dancer2/Core/App.pm l. 837
Failed test 'Query parameters'at t/dsl/parameters.t line 51.Looks like you failed 1 test of 7.I will force install it, it was the ONLY failing test: Failed 1/149 test programs. 1/1476 subtests failed. Cheers … will continue to work on my HTTP Modules
|
@vanHoesel I just released a new development release. Can you please try that? |
@xsawyerx Theo's most recent attempt was with latest dev. I'm testing locally to see if I can reproduce. |
Whoops. |
This looks like Plack 1.0040 DEV since |
Whoops! 1148 fixed the body params.. missed the query params change. ( Same fix applies there too ) |
@vanHoesel new Dancer2 dev release available which fixes that issue ( @xsawyerx ++ ) |
New versions released a few minutes ago: |
@zurborg++ ! Thank you so much. |
How many plugin1 plugins remain? Perhaps the remaining ones could each have a (low pri) issue? |
Main list has a new column denoting whether or not the plugin is pure plugin2. This column can also be used to note PRs to convert to plugin2. Just thought it would be an idea to see how many we need to convert. |
I think we can close this ticket now. Yes? :) |
Yes. |
I'm still using this ticket to track updates to pure Plugin2 which so far has been done for 18 out of 67 plugins. Perhaps my checklist could be moved over to the wiki. |
What's the recommended procedure for converting a plugin that may import an unspecified number of keywords into the app? I use Dancer2::Plugin::LogContextual, which imports a set of keywords via A bit o' sample code:
|
@SysPete Is this still relevant? Guessing not, but we can perhaps move anything you need to the wiki if so? |
This is a ticket to track all the plugins that do not work on the new plugin system and also which ones have been converted to pure plugin2.
Release OK or fixed/PR in repo: 61/68 ~ 90%
👍 Latest release OK (59/68):
👍 Release broken but fixed in GH upstream:
👎 Release broken but PR submitted:
❓ Unknown (no tests)
The text was updated successfully, but these errors were encountered: