Move away from HTTP::Body
#1090
Comments
|
Totally agree! @xsawyerx++ The merged PR for |
|
I was about to revise my |
|
Just updated Plack locally to its latest release (1.0039). Plack::Request still uses HTTP::Body even though was released after the above merge.. #weird. |
|
D'Oh. Plack 1.0039 was a bugfix release.. No 'new feature' release has been made for Plack since the PR to remove HTTP::Body was merged. |
|
@veryrusty Thank you for looking into this and (hopefully) taking it on. :) |
|
Challenge accepted :) |
|
I'm interested in this one - I'm looking at how much work it would be to swap HTTP::Body out of Dancer1, too, as part of PerlDancer/Dancer#1140. I suspect it'll be too much work to justify on D1, though; if so, I'll come up with some kind of workaround for it instead - HTTP::Body works well enough for us, other than its rather weird body handling (that the body is available via a filehandle for some request types, but not others) |
|
@bigpresh D2's request object inherits from Plack::Request, so I'm waiting for a Plack release that has this change (being #lazy). For D1, have a look at the change that went into Plack::Request. |
|
@veryrusty Is such a release of |
|
Note for self: Plack 1.0040 TRIAL is out, with HTTP::Body replaced with HTTP::Entity::Parser |
|
Plack 1.0040 TRIAL breaks our body param handling. Working on a fix.. |
|
Fix for body param passing in #1148. |
|
Where are we now? |
|
I started on this a couple of weeks ago; then got distracted fixing the HMV parameter encoding issues. I'm not going to be able to dedicate time to it till December. |
|
No rush. :) |
|
Resolved by #1406. Closing. |
[ BUG FIXES ]
* GH #1304: Fix the order by which config files are loaded, independently
of their filename extension (Alberto Simões, Russell @veryrusty Jenkins)
* GH #1400: Fix infinite recursion with exceptions that use circular
references. (Andre Walker)
* GH #1430: Fix `dancer2 gen` from source directory when Dancer2 not
installed. (Tina @perlpunk Müller - Tina)
* GH #1434: Add `validate_id` method to verify a session id before
requesting the session engine fetch it from its data store.
(Russell @veryrusty Jenkins)
* GH #1435, #1438: Allow XS crush_cookie methods to return an arrayref
of values. (Russell @veryrusty Jenkins)
* GH #1090, #1406: Replace HTTP::Body with HTTP::Entity::Parser in
Dancer2::Core::Request. (Russell @veryrusty Jenkins)
* GH #1443: Update copyright year (Joseph Frazer)
* GH #1445: Use latest HTTP::Headers::Fast (Russell @veryrusty Jenkins)
[ ENHANCEMENTS ]
* GH #1432: Support Content-Disposition of inline in
send_file() (Dave Webb)
* PR #1433: Verbose testing in AppVeyor (Graham Knop)
* PR #1354: TemplateToolkit template engine will log (at debug level)
if a template is not found. (Kiel R Stirling, Russell @veryrusty Jenkins)
[ DOCUMENTATION ]
* GH #1317: Document serializer configuration (sdeseille)
* PR #1426: Move performance improvement information from Migration guide
to Deployment (Pedro Melo)
[ BUG FIXES ]
* GH #1090, #1406: Replace HTTP::Body with HTTP::Entity::Parser in
Dancer2::Core::Request. (Russell @veryrusty Jenkins)
* GH #1292: Fix multiple attribute definitions within Plugins
(Nigel Gregoire)
* GH #1304: Fix the order by which config files are loaded, independently
of their filename extension (Alberto Simões, Russell @veryrusty Jenkins)
* GH #1400: Fix infinite recursion with exceptions that use circular
references. (Andre Walker)
* GH #1430: Fix `dancer2 gen` from source directory when Dancer2 not
installed. (Tina @perlpunk Müller - Tina)
* GH #1434: Add `validate_id` method to verify a session id before
requesting the session engine fetch it from its data store.
(Russell @veryrusty Jenkins)
* GH #1435, #1438: Allow XS crush_cookie methods to return an arrayref
of values. (Russell @veryrusty Jenkins)
* GH #1443: Update copyright year (Joseph Frazer)
* GH #1445: Use latest HTTP::Headers::Fast (Russell @veryrusty Jenkins)
* PR #1447: Fix missing build requires (Mohammad S Anwar)
[ ENHANCEMENTS ]
* PR #1354: TemplateToolkit template engine will log (at debug level)
if a template is not found. (Kiel R Stirling, Russell @veryrusty Jenkins)
* GH #1432: Support Content-Disposition of inline in
send_file() (Dave Webb)
* PR #1433: Verbose testing in AppVeyor (Graham Knop)
[ DOCUMENTATION ]
* GH #1314: Documentation tweaks (David Precious)
* GH #1317: Document serializer configuration (sdeseille)
* GH #1386: Add Hello World example (Gabor Szabo)
* PR #1408: List project development resources (Steve Dondley)
* PR #1426: Move performance improvement information from Migration guide
to Deployment (Pedro Melo)
I've been wanting to do this for a very long time.
Plackdid this in plack/Plack#537.The text was updated successfully, but these errors were encountered: