Rollup anchor for ink! smart contracts #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from main repo
|
Thanks for the contribution! The Phala team is at ETHcc event. So the review and communication may take longer than expected. I will start reviewing this PR from Monday. |
HashWarlock
reviewed
Jul 17, 2023
kvinwang
reviewed
Jul 18, 2023
kvinwang
reviewed
Jul 18, 2023
- All methods in a 'Openbrush Trait' are callable (#[ink::message]) - All inner methods are in a Trait named Internal and are not callable
…bute macro `openbrush::trait_definition`
…sion for ink! smart contract)
|
Sorry for the very late reply. Was too busy in preparing hackathon, etc. I'm reviewing it right now. |
h4x3rotab
reviewed
Sep 13, 2023
h4x3rotab
reviewed
Sep 14, 2023
ink/crates/phat_rollup_anchor_ink/src/traits/meta_transaction.rs
Outdated
Show resolved
Hide resolved
…ay protection. Remove unnecessary "public key registering".
h4x3rotab
approved these changes
Sep 21, 2023
| } | ||
|
|
||
| /// Converts a compressed public key to SS58 format | ||
| fn pub_key_to_ss58(pub_key: &[u8; 33]) -> AccountId { |
There was a problem hiding this comment.
Nit: AccountId is just [u8; 32] under the hood. SS58 only kicks in when it's displayed on the frontend. So I suggest to name it get_ecdsa_account_id()
There was a problem hiding this comment.
I renamed the function
| @@ -337,12 +339,21 @@ impl<'a> SubmittableRollupTx<'a> { | |||
| } | |||
| } | |||
|
|
|||
| /// Hashing function for bytes | |||
| fn pub_key_to_ss58(input: &[u8]) -> [u8; 32] { | |||
There was a problem hiding this comment.
I renamed the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rollup anchor for ink! smart contracts
simple phat contract for the tests
simple ink smart contract for the tests