Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat issues #121

Merged
merged 8 commits into from
Jan 7, 2021
Merged

Compat issues #121

merged 8 commits into from
Jan 7, 2021

Conversation

tpoisot
Copy link
Member

@tpoisot tpoisot commented Dec 3, 2020

ignore the manifest and see what's up with CompatHelper

@tpoisot tpoisot marked this pull request as draft December 3, 2020 01:32
@tpoisot
Copy link
Member Author

tpoisot commented Dec 3, 2020

So, the CI test is running 1.3 - 1.5, but CompatHelper runs 1.2 -- maybe this is the problem?

@tpoisot
Copy link
Member Author

tpoisot commented Dec 3, 2020

I have also given /test its own project - which versions of Julia do you need to support?

@evadelmas
Copy link
Collaborator

evadelmas commented Dec 3, 2020

which versions of Julia do you need to support?

[1.3.0 - 1.5.3]

@evadelmas
Copy link
Collaborator

Maybe that's another issue:

Your new version pull request does not meet the guidelines for auto-merging. Please make sure that you have read the General registry README. The following guidelines were not met:

  • The following dependencies do not have a [compat] entry that is upper-bounded and only includes a finite number of breaking releases: DiffEqCallbacks, OrdinaryDiffEq

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #121 (307a065) into master (fe454b8) will increase coverage by 1.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   90.19%   91.36%   +1.16%     
==========================================
  Files          16       16              
  Lines        1204     1146      -58     
==========================================
- Hits         1086     1047      -39     
+ Misses        118       99      -19     
Flag Coverage Δ
unittests 91.36% <ø> (+1.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/checks.jl 28.26% <0.00%> (-4.40%) ⬇️
src/make_parameters.jl 96.87% <0.00%> (-0.10%) ⬇️
src/dBdt.jl 99.18% <0.00%> (-0.08%) ⬇️
src/rewiring/parameters/updateParameters.jl 98.33% <0.00%> (-0.06%) ⬇️
src/simulate.jl 98.27% <0.00%> (-0.03%) ⬇️
src/temperature_dependence_functions.jl 97.50% <0.00%> (-0.03%) ⬇️
src/random.jl 100.00% <0.00%> (ø)
src/trophic_rank.jl 100.00% <0.00%> (ø)
src/rewiring/ADBM.jl 100.00% <0.00%> (ø)
src/biological_rates.jl 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe454b8...307a065. Read the comment docs.

@evadelmas evadelmas merged commit 307a065 into master Jan 7, 2021
@evadelmas evadelmas deleted the tpoisot-patch-manifest branch January 8, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants