-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPI model fixes #907
SPI model fixes #907
Conversation
Income tax error as of commit 36489be
|
Income tax error as of commit 1f9766c
|
1f9766c
to
0a9e4b5
Compare
As of commit 3944d41:
|
As of commit 3badd07:
|
Further testing seems to demonstrate that the SPI doesn't properly apply the Property Allowance. Without the allowance, as of our last commit, we had the following error rates:
If I set the Property Allowance to 0 within the parameters, the output jumps to:
This is supported by certain particular records, such as 630113, which has no employment income, a dividend income of £72,000, and a property income of £28,200, so we'd expect an adjusted net income of £99,200 (property allowance is calculated before all other allowances, and only on property), but SPI reports a TAXINC value of £100,200. |
Note, too, that I tried various other approaches to fixing the property allowance issue, including changing where the property allowance was calculated, updating it and the dividend allowance parameter value, and checking to ensure that tax is assessed correctly on both types of income, but none of those were successful. |
As of commit 1d6dc20:
|
As of commit 3660a06:
|
As of commit b18fffe:
|
As of commit a07861e:
|
As of commit fa70a97:
|
As of commit 47bb39c:
|
As of commit 2df0f27:
|
As of commit 4592b4b:
|
As of commit 255de32:
|
…utions are calculated
…ts not yet passing
…o all income types
b0f77ab
to
ca5c835
Compare
Final outcome:
|
Fixes #910
Fixes #901
Fixes #899
Fixes #911
Fixes #896
PR makes various changes to the UK country package to calibrate our output to the SPI 2020/21 dataset. It also ensures that we properly calculate Scottish income taxes.