Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Popup ID on the editor page in bold near the top. #583

Closed
danieliser opened this issue Aug 19, 2018 · 3 comments
Closed

Show Popup ID on the editor page in bold near the top. #583

danieliser opened this issue Aug 19, 2018 · 3 comments

Comments

@danieliser
Copy link
Member

No description provided.

@fpcorso
Copy link
Contributor

fpcorso commented Jul 16, 2020

@danieliser Looking for the right place to add this. Originally, I was thinking we could add a slightly gray - #XXXX next to the heading. Such as Edit Popup - #1111.
image

But, that title is apparently brought directly from the CPT's edit-item key without any filters so it isn't easy to add something there that dynamically changes:

$title = $post_type_object->labels->edit_item;
to

<h1 class="wp-heading-inline">
<?php
echo esc_html( $title );
?>
</h1>

However, there is an edit_form_top hook right after the heading which can be added to like this:
image

Thoughts on location? Also, we just need to output the ID, right? Or, should we add additional explanation text?

@danieliser
Copy link
Member Author

I like the latter one, is there one above the Edit Popup title, and if so does break the floats of the buttons?

fpcorso added a commit that referenced this issue Jul 23, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Jul 23, 2020

@danieliser There isn't a good action for above the heading. That said, I think it is more consistent with how core outputs attributes by being underneath.

I went ahead and added it underneath and decreased the font size a little so it isn't quite as big as the main heading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants