Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't save cookie site wide checkbox unchecked. #642

Closed
danieliser opened this issue Feb 26, 2019 · 6 comments
Closed

Can't save cookie site wide checkbox unchecked. #642

danieliser opened this issue Feb 26, 2019 · 6 comments
Labels
Milestone

Comments

@danieliser
Copy link
Member

danieliser commented Feb 26, 2019

User says he can't save cookies with site wide cookies disabled.

https://secure.helpscout.net/conversation/703282259/10383/

@fpcorso fpcorso added this to the v1.12 milestone Jun 5, 2020
@fpcorso fpcorso modified the milestones: v1.12, v1.13 Aug 6, 2020
@fpcorso fpcorso modified the milestones: v1.13, v1.14 Oct 1, 2020
@fpcorso fpcorso modified the milestones: v1.14, v1.15 Oct 15, 2020
@fpcorso
Copy link
Contributor

fpcorso commented Dec 3, 2020

@danieliser This sitewide checkbox has been broken for over two years now so we know no one is using it. And yet, we have only received a couple of tickets about it all year.

Should we just remove the feature since it is apparently something no one will miss or should we go ahead and fix it?

@danieliser
Copy link
Member Author

danieliser commented Dec 9, 2020

@fpcorso that could be an option honestly.

Would probably simplify a few things too,

@fpcorso
Copy link
Contributor

fpcorso commented Dec 11, 2020

@danieliser What was the original use-case for this feature? Why would someone want a cookie that is not site-wide?

@danieliser
Copy link
Member Author

@fpcorso - Essentially having a single popup across multiple pages, but making users convert on each of them separately. That may just be viewing the popup on every page.

Its been used, but rarely.

@fpcorso
Copy link
Contributor

fpcorso commented Dec 18, 2020

@danieliser We do know no one has used it in the last two years since it's been broken for that long. That use case does sound interesting but, based on searches in HelpScout, it doesn't look like that many people have asked for it.

So, should we remove it or fix it?

@danieliser
Copy link
Member Author

@fpcorso Fixing it is obviously the simpler route all things considered. If we opt to remove it we now have to update docs, likely put an explanation of its removal, respond to tickets for users who suddenly find the option missing (even if they weren't using it 🤦‍♂️) etc.

But I do like the prospect of starting to remove the unneccessary fluff. I loved that about Ahoy.

So if we can't find any evidence its in use, maybe hide it as an option and add some way to filter it back on at first. If we go 3-4 months without any support requests, then we can officially remove it.

@fpcorso fpcorso modified the milestones: v1.15, v1.16 Dec 21, 2020
danieliser added a commit that referenced this issue Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants